Fix getmntent check with -Werror. #799
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipeborato
approved these changes
May 24, 2023
|
The test program cannot be run. It always fails with a segmentation fault. A better one would be: |
|
The test is not executed, but it needs to compile without warning if OP wants to use -Werror. |
|
The current check script will however compile even if mntent.h doesn't contain getmntent. The default declaration of getmntent is fine. The check could thus be simplified to A more (pointless) thorough check that checks for valid content of mntent.h could perhaps also do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a warning. The test is just compile tested and the return value is not used anyway.
Also, in my private build I compile with "-Werror" and without this patch this fails.
It also fails to build:
../libs/pbd/mountpoint.cc:114:10: fatal error: sys/ucred.h: Datei oder Verzeichnis nicht gefunden 114 | #include <sys/ucred.h> | ^~~~~~~~~~~~~ compilation terminated.